Difference between revisions of "RailsEdit"

(Steps to get to DoneDone)
(What (summary))
 

(23 intermediate revisions by 3 users not shown)



Line 1: Line 1:
 
<noinclude><big>[[OurWork]] < [[DevelopmentTeam]] < [[DevelopmentTeamPriorities|Priorities]] < </noinclude>[[RailsEdit]] {{JustTinyEditIcon|RailsEdit}}<noinclude></big>
 
<noinclude><big>[[OurWork]] < [[DevelopmentTeam]] < [[DevelopmentTeamPriorities|Priorities]] < </noinclude>[[RailsEdit]] {{JustTinyEditIcon|RailsEdit}}<noinclude></big>
 
__NOTOC__
 
__NOTOC__
 +
 +
== Remaining Bugs ==
 +
* Editing a page that is transcluded doesn't appear to change page_touched on pages it's transcluded onto
 +
* Editing a section and hitting 'save' without making any changes adds an extra line
  
 
== What (summary) ==
 
== What (summary) ==
 
Replace Mediawiki's editing functionality with our own homegrown editor.
 
Replace Mediawiki's editing functionality with our own homegrown editor.
 +
 
== Why this is important ==
 
== Why this is important ==
 
As we move towards profiles we need to be able to integrate functionality of  
 
As we move towards profiles we need to be able to integrate functionality of  
 
+
We can edit!
 
== [[DoneDone]] ==
 
== [[DoneDone]] ==
 
* <s>Merge with compostus branch</s>
 
* <s>Merge with compostus branch</s>
 
* Require CAPTCHA iff any of these conditions are met:
 
* Require CAPTCHA iff any of these conditions are met:
** Non-sysops add external links
+
** <s>Non-sysops add external links....</s>
 
** Anyone add text that triggers spam filter
 
** Anyone add text that triggers spam filter
  
Line 22: Line 27:
 
** <s>CategoryLinks/TemplateLinks/PageLinks all updated properly, based on results from Parser</s>
 
** <s>CategoryLinks/TemplateLinks/PageLinks all updated properly, based on results from Parser</s>
 
** <s>PageCache is recreated, based on results from parser.</s>
 
** <s>PageCache is recreated, based on results from parser.</s>
** Users on watchlist are notified (by email or otherwise)
+
** <s>Users on watchlist are notified (by email or otherwise)</s> -- appears to be done
** RecentChanges / Actions are created upon edit (autopatrolled as before)
+
** <s>RecentChanges</s> / Actions are created upon edit (autopatrolled as before)
 +
*** Actions wait until we figure out what's wrong
 +
 
 +
* Audited for javascript injection vulnerabilities!
 +
** Escape ALL user-submitted content.
  
 
== Steps to get to [[DoneDone]] ==
 
== Steps to get to [[DoneDone]] ==
Line 29: Line 38:
 
** If not, write tests.
 
** If not, write tests.
 
** Cases:
 
** Cases:
*** Edit section
+
*** <s>Edit section</s>
*** Edit nonexistent page
+
*** <s>Edit nonexistent page</s>
*** Add new section
+
*** <s>Add new section</s>
 +
*** <s>Edit old revision.</s>
 +
*** <s>Diff</s>
 +
*** <s>Preview</s>
  
* Fix section edit links not showing up
+
* <s>Fix section edit links not showing up</s>
  
* Same code pathway for parsing on edit and on page_cache update
+
* <s>Same code pathway for parsing on edit and on page_cache update</s>
 +
* <s>Section editing doesn't handle bullets right</s>
 +
* <s>Get {{SERVERNAME}} to work.</s>
 +
* When a template is edited, all pages that include the template need to be purged and their links rebuilt
  
 
== Discussion ==
 
== Discussion ==
  
 +
</noinclude>
 +
[[Category:DevelopmentTeam]]
 
[[Category:OpenTask]]
 
[[Category:OpenTask]]
[[Category:DevelopmentTeam]]
 
</noinclude>
 

Latest revision as of 22:41, 2 June 2008

OurWork Edit-chalk-10bo12.png


Remaining Bugs

  • Editing a page that is transcluded doesn't appear to change page_touched on pages it's transcluded onto
  • Editing a section and hitting 'save' without making any changes adds an extra line

What (summary)

Replace Mediawiki's editing functionality with our own homegrown editor.

Why this is important

As we move towards profiles we need to be able to integrate functionality of We can edit!

DoneDone

  • Merge with compostus branch
  • Require CAPTCHA iff any of these conditions are met:
    • Non-sysops add external links....
    • Anyone add text that triggers spam filter
  • Implement spam filter using Akismet
    • Applied to newly added text
    • Get commercial key
  • Upon edit:
    • email tags are graphic-substituted
    • Page text is pre-processed by mediawiki Parser, saved as a new revision
    • CategoryLinks/TemplateLinks/PageLinks all updated properly, based on results from Parser
    • PageCache is recreated, based on results from parser.
    • Users on watchlist are notified (by email or otherwise) -- appears to be done
    • RecentChanges / Actions are created upon edit (autopatrolled as before)
      • Actions wait until we figure out what's wrong
  • Audited for javascript injection vulnerabilities!
    • Escape ALL user-submitted content.

Steps to get to DoneDone

  • Verify by hand that the code we refactored works correctly.
    • If not, write tests.
    • Cases:
      • Edit section
      • Edit nonexistent page
      • Add new section
      • Edit old revision.
      • Diff
      • Preview
  • Fix section edit links not showing up
  • Same code pathway for parsing on edit and on page_cache update
  • Section editing doesn't handle bullets right
  • Get aboutus.com to work.
  • When a template is edited, all pages that include the template need to be purged and their links rebuilt

Discussion



Retrieved from "http://aboutus.com/index.php?title=RailsEdit&oldid=15633058"